Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor name of from/to_pb_message and from/to_pb_value to be descriptive one is used in the workflow definitions and the other in params_dict #73

Open
lfse-slafleur opened this issue Sep 19, 2024 · 0 comments

Comments

@lfse-slafleur
Copy link
Member

lfse-slafleur commented Sep 19, 2024

{from,to}_pb_message are used for workflow definitions while {from,to}_pb_value are used to pack a params_dict value into protobuf Struct to accompany a JobSubmission. These names are not descriptive at all and should be altered to showcase their intended goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant