Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_time_series_db_cleanup #46

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarkTNO
Copy link
Contributor

@MarkTNO MarkTNO commented Dec 19, 2024

No description provided.

@MarkTNO MarkTNO linked an issue Dec 19, 2024 that may be closed by this pull request

The proposal is to create a `job_deletions` queue to which an SDK can publish. The orchestrator will
subscribe to this queue and remove the data from the time series database.
Also on a `job_cancellations` message, the orchestrator should, after termination of the celery job,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose that we only keep the timeseries db on a successfull result. If it is an error result, cancellation, timeout or whatever, we should remove any artifacts from the timeseries db.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point.
I added an issue: How to obtain the output ESDL id in case of a cancellation/timeout?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I added a proposal to deal with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup data in timeseries database
3 participants