Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vista3d eval and add zero shot descriptions #672

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

yiheng-wang-nv
Copy link
Collaborator

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Status

Ready/Work in progress/Hold

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

Signed-off-by: Yiheng Wang <[email protected]>
Copy link
Collaborator

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good to me.
I have another question regarding the extra metric in the training config, seems it'n not used, do we need include it here? Thanks.
https://github.com/Project-MONAI/model-zoo/blob/dev/models/vista3d/configs/train.json#L355C10-L355C28
https://github.com/Project-MONAI/model-zoo/blob/dev/models/vista3d/configs/train.json#L369

@yiheng-wang-nv
Copy link
Collaborator Author

Thanks for the update, looks good to me. I have another question regarding the extra metric in the training config, seems it'n not used, do we need include it here? Thanks. https://github.com/Project-MONAI/model-zoo/blob/dev/models/vista3d/configs/train.json#L355C10-L355C28 https://github.com/Project-MONAI/model-zoo/blob/dev/models/vista3d/configs/train.json#L369

Hi @KumoLiu , thanks for the question. There are some configs that are not used, like additional_metrics as you mentioned. I'm not sure why we include it in the config file. Hi @heyufan1995 , could you provide some information here? Thanks!

Signed-off-by: Yiheng Wang <[email protected]>
@heyufan1995
Copy link
Member

heyufan1995 commented Sep 25, 2024

Thanks for the update, looks good to me. I have another question regarding the extra metric in the training config, seems it'n not used, do we need include it here? Thanks. https://github.com/Project-MONAI/model-zoo/blob/dev/models/vista3d/configs/train.json#L355C10-L355C28 https://github.com/Project-MONAI/model-zoo/blob/dev/models/vista3d/configs/train.json#L369

Hi @KumoLiu , thanks for the question. There are some configs that are not used, like additional_metrics as you mentioned. I'm not sure why we include it in the config file. Hi @heyufan1995 , could you provide some information here? Thanks!

Seems like it was not used. It was created by Wenqi @wyli

@yiheng-wang-nv
Copy link
Collaborator Author

/build

@yiheng-wang-nv yiheng-wang-nv merged commit bb9416f into Project-MONAI:dev Sep 26, 2024
4 checks passed
@yiheng-wang-nv yiheng-wang-nv deleted the update-vista3d-eval branch September 26, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants