Update vista3d to use MONAI components #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiheng Wang <[email protected]>
|
/build |
Signed-off-by: Yiheng Wang <[email protected]>
KumoLiu
reviewed
Aug 26, 2024
|
/build |
|
Hi @KumoLiu , |
KumoLiu
approved these changes
Aug 26, 2024
|
/build |
|
/build |
yiheng-wang-nv
commented
Aug 26, 2024
| @@ -243,8 +243,8 @@ def _iteration(self, engine: SupervisedEvaluator, batchdata: dict[str, torch.Ten | |||
| label_set = np.arange(output_classes).tolist() | |||
| label_prompt = torch.tensor(label_set).to(engine.state.device).unsqueeze(-1) | |||
| # point prompt is generated withing vista3d,provide empty points | |||
| points = torch.zeros(label_prompt.shape[0], 1, 3) | |||
| point_labels = -1 + torch.zeros(label_prompt.shape[0], 1) | |||
| points = torch.zeros(label_prompt.shape[0], 1, 3).to(inputs.device) | |||
There was a problem hiding this comment.
HI @heyufan1995 , could you help to confirm if the changes here are correct? I got device mismatch error thus changed here, thanks in advance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
A few sentences describing the changes proposed in this pull request.
Status
Ready/Work in progress/Hold
Please ensure all the checkboxes:
./runtests.sh --codeformat.versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").