Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vista2d #618

Merged
merged 17 commits into from
Aug 23, 2024
Merged

add vista2d #618

merged 17 commits into from
Aug 23, 2024

Conversation

yiheng-wang-nv
Copy link
Collaborator

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Status

Ready/Work in progress/Hold

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

yiheng-wang-nv and others added 5 commits August 15, 2024 15:27
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review August 20, 2024 10:26
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
@Nic-Ma
Copy link
Collaborator

Nic-Ma commented Aug 21, 2024

I think we have too many datalists in this PR, it's more than 180k lines..If we put the same things in a tutorial later, I feel it's not acceptable.
Can we refer to the MAISI bundle?
https://github.com/Project-MONAI/model-zoo/blob/dev/models/maisi_ct_generative/large_files.yml#L16

Thanks.

@yiheng-wang-nv
Copy link
Collaborator Author

/build

@mingxin-zheng
Copy link
Contributor

I think we have too many datalists in this PR, it's more than 180k lines..If we put the same things in a tutorial later, I feel it's not acceptable. Can we refer to the MAISI bundle? https://github.com/Project-MONAI/model-zoo/blob/dev/models/maisi_ct_generative/large_files.yml#L16

Thanks.

I agree with @Nic-Ma because

  • Long data lists can be more prone to merge conflicts, especially if multiple contributors are updating the same data sets.
  • Redundancy Issues: if MONAI tutorials need to use these datalists, it has to either make a copy there, or depends on raw github links that point to the model zoo repo, which is not the preferred way of maintaining these repos.

Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator Author

For the blossom CI issue, need to enable opencv lib in the dockerfile.

Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator Author

/build

1 similar comment
@yiheng-wang-nv
Copy link
Collaborator Author

/build

@yiheng-wang-nv
Copy link
Collaborator Author

/build

@yiheng-wang-nv
Copy link
Collaborator Author

/build

@yiheng-wang-nv
Copy link
Collaborator Author

Discussed with @mingxin-zheng offline, for suggestions that may impact the bundle's internal logics, we will connect to the original author: @myron , and decide if we need to change in next version.
For this version, we will not modify any logics and only fix code format issues or other obvious bugs.

Although this PR is submitted by myself, the bundle content is totally copied from the original author side.

@yiheng-wang-nv yiheng-wang-nv merged commit d593a05 into Project-MONAI:dev Aug 23, 2024
4 checks passed
@yiheng-wang-nv yiheng-wang-nv deleted the add-vista2d branch August 23, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants