Add option to validate at training start of deepedit #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
yiheng-wang-nv
approved these changes
Oct 11, 2023
|
/build |
|
need to use new feature in MONAI dev branch, thus it requires a new monai version (currently 1.2.0 shown in https://github.com/Project-MONAI/model-zoo/pull/515/files#diff-90cacb33aaa1f750be54f039f8d7b09347e90155d8293c52c4fd7c3f79420575L30). |
Signed-off-by: Mingxin Zheng <[email protected]>
|
I hacked the ci install dev branch of monai for testing purposes 8484dbd. That may not be something interesting to keep, but just to get an idea if the bundle can pass test. |
This reverts commit 8484dbd.
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
|
After discussion with @yiheng-wang-nv , I reverted and will wait for a new rc tagging, |
|
sure, I'll tag another rc today to test the latest feature |
Signed-off-by: Mingxin Zheng <[email protected]>
Nic-Ma
approved these changes
Oct 11, 2023
|
/build |
1 similar comment
|
/build |
|
some errors testing with rc4, probably due to #517: |
|
possible fix |
Signed-off-by: KumoLiu <[email protected]>
|
/build |
Signed-off-by: Mingxin Zheng <[email protected]>
|
/build |
2 similar comments
|
/build |
|
/build |
yiheng-wang-nv
pushed a commit
to yiheng-wang-nv/model-zoo
that referenced
this pull request
Jul 29, 2024
### Description Modify bundle as the new feature enabled in Project-MONAI/MONAI@fc1350a ### Status **Ready/Work in progress/Hold** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`). --------- Signed-off-by: Mingxin Zheng <[email protected]> Signed-off-by: KumoLiu <[email protected]> Co-authored-by: KumoLiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify bundle as the new feature enabled in Project-MONAI/MONAI@fc1350a
Status
Ready/Work in progress/Hold
Please ensure all the checkboxes:
./runtests.sh --codeformat.versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").