-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE YET #1775
DO NOT MERGE YET #1775
Conversation
- Migrate from using webpack-merge to a simplified webpack configuration for production builds - Update MonaiLabelPanel to use the new PanelSegmentation component - Replace deprecated segmentation event names and adjust logic accordingly - Remove unused MonaiSegmentation and SegmentationToolbox components to streamline the codebase - Enhance toolbar buttons for
- Remove W3.CSS import from MonaiLabelPanel.css - Integrate Toolbox component into MonaiLabelPanel for segmentation tools - Update viewport subscription logic for improved state management - Clean up segmentation loading logic and ensure
I can continue to work on making other part compatible to OHIF3.9. Looks like there will be bigger changes to switch 3.9 from 3.8. Thanks again for the guide. |
@tangy5 Yes, it's a significant change since Cornerstone3D 2.0 was released. It won't happen very often. |
Let me work on this one time. I will take care from here. @sedghi you can help to review it once I submit the PR |
WIP: https://github.com/Project-MONAI/MONAILabel/tree/sachi/ohifv3 This should take care of most of the things.
Need to add back new other things like Active Learning.. |
Great, after this is finished, I will add VISTA3D supports to OHIF 3.9. |
@SachidanandAlle yes, let me know when to review |
@SachidanandAlle, consider merging a formatting PR first to reduce the noise from numerous formatting fixes. |
|
@sedghi need your help. I can run auto segmentation, point prompts (interactive for deepgrow/deepedit/sam2/vista3d) and also subset/class prompts. However for testing, I can do right click and open and run things in monailabel. I might be missing some config in the init for extension/mode. need your help. Otherwise TODO:
|
@SachidanandAlle Does your PR have my changes here? shall we close this one? |
Yes.. I have cherry picked the needed ones to support ohif latest. During this I might have missed something. That can be one reason for disabled button for monailabel mode |
Let's close this one, and I'll work on that one. |
Thanks :) |
Migrating the Monai Label plugin for the upcoming OHIF 3.9 and Cornerstone3D 2.0 to observe the migration process and take notes.
The AutoSegmentation works, but I doubt there's much left to do for the rest of it to function properly.