Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE YET #1775

Closed
wants to merge 4 commits into from
Closed

DO NOT MERGE YET #1775

wants to merge 4 commits into from

Conversation

sedghi
Copy link
Contributor

@sedghi sedghi commented Nov 5, 2024

Migrating the Monai Label plugin for the upcoming OHIF 3.9 and Cornerstone3D 2.0 to observe the migration process and take notes.

The AutoSegmentation works, but I doubt there's much left to do for the rest of it to function properly.

-  Migrate from using webpack-merge to a simplified webpack configuration for production builds
-  Update MonaiLabelPanel to use the new PanelSegmentation component
-  Replace deprecated segmentation event names and adjust logic accordingly
-  Remove unused MonaiSegmentation and SegmentationToolbox components to streamline the codebase
-  Enhance toolbar buttons for
-  Remove W3.CSS import from MonaiLabelPanel.css
-  Integrate Toolbox component into MonaiLabelPanel for segmentation tools
-  Update viewport subscription logic for improved state management
-  Clean up segmentation loading logic and ensure
@tangy5
Copy link
Collaborator

tangy5 commented Nov 8, 2024

I can continue to work on making other part compatible to OHIF3.9. Looks like there will be bigger changes to switch 3.9 from 3.8.
Will check one by one.

Thanks again for the guide.

@sedghi
Copy link
Contributor Author

sedghi commented Nov 8, 2024

@tangy5 Yes, it's a significant change since Cornerstone3D 2.0 was released. It won't happen very often.
https://www.cornerstonejs.org/docs/migration-guides/intro

@SachidanandAlle
Copy link
Collaborator

Let me work on this one time. I will take care from here. @sedghi you can help to review it once I submit the PR

@SachidanandAlle
Copy link
Collaborator

SachidanandAlle commented Nov 14, 2024

WIP: https://github.com/Project-MONAI/MONAILabel/tree/sachi/ohifv3

This should take care of most of the things.
So far verified

  1. basic auto segmentation
  2. point prompts (deepgrow/deepedit/vista3d/sam2 models)
  3. class prompts (seg/vista models)

Need to add back new other things like Active Learning..

@tangy5
Copy link
Collaborator

tangy5 commented Nov 14, 2024

WIP: https://github.com/Project-MONAI/MONAILabel/tree/sachi/ohifv3

This should take care of most of the things. So far verified

  1. basic auto segmentation
  2. point prompts (deepgrow/deepedit/vista3d/sam2 models)
  3. class prompts (seg/vista models)

Need to add back new other things like Active Learning..

Great, after this is finished, I will add VISTA3D supports to OHIF 3.9.
Thanks again.

@sedghi
Copy link
Contributor Author

sedghi commented Nov 14, 2024

@SachidanandAlle yes, let me know when to review

@sedghi
Copy link
Contributor Author

sedghi commented Nov 14, 2024

@SachidanandAlle, consider merging a formatting PR first to reduce the noise from numerous formatting fixes.

@SachidanandAlle
Copy link
Collaborator

@SachidanandAlle, consider merging a formatting PR first to reduce the noise from numerous formatting fixes.

#1784

@SachidanandAlle
Copy link
Collaborator

SachidanandAlle commented Nov 19, 2024

@sedghi need your help.
https://github.com/Project-MONAI/MONAILabel/tree/sachi/ohifv3

I can run auto segmentation, point prompts (interactive for deepgrow/deepedit/sam2/vista3d) and also subset/class prompts.
But on the main list monai-label mode is not active

However for testing, I can do right click and open and run things in monailabel.
The button is disabled to open a studies in monai-label mode directly.

image

I might be missing some config in the init for extension/mode. need your help.

Otherwise TODO:

  1. Add back active learning section
  2. Add back settings table

image

@sedghi
Copy link
Contributor Author

sedghi commented Nov 19, 2024

@SachidanandAlle Does your PR have my changes here? shall we close this one?

@SachidanandAlle
Copy link
Collaborator

SachidanandAlle commented Nov 19, 2024

Yes.. I have cherry picked the needed ones to support ohif latest. During this I might have missed something. That can be one reason for disabled button for monailabel mode

@sedghi
Copy link
Contributor Author

sedghi commented Nov 19, 2024

Let's close this one, and I'll work on that one.

@SachidanandAlle
Copy link
Collaborator

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants