Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix PatchMerging duplicate merging #8285

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

pooya-mohammadi
Copy link
Contributor

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Fixing issue #8284
In this format there are no duplicates:

t = [
    (0, 0, 0),
    (1, 0, 0),
    (0, 1, 0),
    (0, 0, 1),
    (1, 0, 1),
    (1, 1, 0),
    (0, 1, 1),
    (1, 1, 1),
    ]
print(set(t))
# {(1, 0, 1), (1, 1, 0), (0, 1, 0), (0, 0, 0), (1, 0, 0), (0, 0, 1), (1, 1, 1), (0, 1, 1)}

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM.
Please sighoff to address the DCO issue. Thanks.
https://github.com/Project-MONAI/MONAI/pull/8285/checks?check_run_id=35266268085

@KumoLiu KumoLiu requested review from ericspod and Nic-Ma January 9, 2025 08:13
….com>

I, pooya-mohammadi <[email protected]>, hereby add my Signed-off-by to this commit: 94195a9

Signed-off-by: pooya-mohammadi <[email protected]>
@KumoLiu
Copy link
Contributor

KumoLiu commented Jan 9, 2025

/build

@ericspod ericspod merged commit 1c00ea2 into Project-MONAI:dev Jan 10, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants