Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-14225 it is not possible to reorder the pages from the modal #1551

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

devmiguelangel
Copy link
Contributor

@devmiguelangel devmiguelangel commented Feb 27, 2024

Issue & Reproduction Steps

Expected behavior:
It should be possible to reorder the pages from the modal

Actual behavior:
It is not possible to reorder the pages from the modal

Solution

Fix the sortable component to allow ordering for imported screens

How to Test

  1. Import attached screen
  2. Open screen
  3. Click on See all pages
  4. Try to move the last page to the top

Related Tickets & Packages

FOUR-14225

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@devmiguelangel devmiguelangel self-assigned this Feb 27, 2024
Copy link

cypress bot commented Feb 27, 2024

1 failed test on run #520 ↗︎

1 0 0 2 Flakiness 0

Details:

FOUR-14225 it is not possible to reorder the pages from the modal
Project: screen-builder Commit: 86c37ed22a
Status: Failed Duration: 02:07 💡
Started: Feb 27, 2024 9:21 PM Ended: Feb 27, 2024 9:23 PM
Failed  Pagination.spec.js • 1 failed test • CI - Chrome

View Output

Test Artifacts
Pagination > Should Not Be Visible Test Replay Screenshots
Failed  DatePicker.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  Task.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  RecordList.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  DeviceVisivilityInspector.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts

The first 5 failed specs are shown, see all 80 specs in Cypress Cloud.

Review all test suite changes for PR #1551 ↗︎

@caleeli caleeli merged commit 73e76be into feature/FOUR-13446 Feb 27, 2024
6 of 12 checks passed
@caleeli caleeli deleted the bugfix/FOUR-14225 branch February 27, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants