Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix design of page creation #1549

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Fix design of page creation #1549

merged 3 commits into from
Feb 28, 2024

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Feb 27, 2024

Issue & Reproduction Steps

Fix screen creation popup.

Solution

  • Adjust style to match as best possible the mockups

How to Test

Create a new Page

image

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

Copy link

cypress bot commented Feb 27, 2024

1 failed test on run #532 ↗︎

1 0 0 0 Flakiness 0

Details:

Fix design of page creation
Project: screen-builder Commit: f8d33a8955
Status: Failed Duration: 02:15 💡
Started: Feb 28, 2024 5:57 PM Ended: Feb 28, 2024 6:00 PM
Failed  Pages.spec.js • 1 failed test • CI - Chrome

View Output

Test Artifacts
Pages and navigations > Basic default value Test Replay Screenshots
Failed  pagesDropdown.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  DatePicker.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  Task.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts
Failed  RecordList.spec.js • 0 failed tests • CI - Chrome

View Output

Test Artifacts

The first 5 failed specs are shown, see all 80 specs in Cypress Cloud.

Review all test suite changes for PR #1549 ↗︎

@caleeli caleeli merged commit df297ef into feature/FOUR-13446 Feb 28, 2024
3 of 9 checks passed
@caleeli caleeli deleted the bugfix/FOUR-14230 branch February 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants