Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-10870: Added data-tests tags to AI Section controls #1447

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Conversation

TinCodes
Copy link
Contributor

@TinCodes TinCodes commented Oct 3, 2023

Expected behavior:
data-test attributes were expected to be present for some controls on Screen Builder.

Actual behavior:
data-test attributes are not present for some controls on Screen Builder.

Solution

  • Added data-test attribute to buttons on screen builder elements such as Copy, Delete and Apply Changes.
  • Added data-test attribute to the AI Section div to make it easier for QA to get the generated element.

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@TinCodes TinCodes requested a review from agustinbusso October 3, 2023 14:25
@TinCodes TinCodes changed the base branch from develop to next October 3, 2023 14:26
@processmaker-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryancooley ryancooley merged commit 4474d6f into next Oct 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants