Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading button update #1445

Merged
merged 11 commits into from
Sep 29, 2023
Merged

Loading button update #1445

merged 11 commits into from
Sep 29, 2023

Conversation

nolanpro
Copy link
Contributor

@nolanpro nolanpro commented Sep 29, 2023

Feature to allow the submit button to turn into a loading spinner instead of a full screen interstitial

How to Test

  • Create a screen and add a submit button. Enable "Loading submit button"
  • Create a process with a task for the screen and enable "Display next assigned task to assignee"
  • Verify the button turns into a spinner and stays a spinner until the next screen is displayed

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:package-savedsearch:fix-test-teardown

@nolanpro nolanpro changed the base branch from develop to next September 29, 2023 00:03
@processmaker-sonarqube
Copy link

@ryancooley ryancooley merged commit d4adb2e into next Sep 29, 2023
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants