Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ES modules #18

Open
markusjwetzel opened this issue Apr 20, 2024 · 0 comments
Open

Update to ES modules #18

markusjwetzel opened this issue Apr 20, 2024 · 0 comments

Comments

@markusjwetzel
Copy link
Contributor

find-cache-dir was updated, so that it can now only be used with ES modules. Longterm it makes sense to update the whole react-kickstarter package to ES modules.

After updating to ES modules we can upgrade find-cache-dir to the newest version. Also we can remove pkg-dir from the dependencies as this package is only listed in the dependencies to pin it to the last version that do not require ES modules.

Here's how we can update to ES modules:
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

Hint: On the first attempt of upgrading to ES modules it was hard to replace conditional require() calls. We might be able to replace these require() calls by import() calls, but this would make the code async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant