Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server URL with trailing / produces unexpected error #45

Open
pinusc opened this issue Jan 23, 2023 · 0 comments · May be fixed by #46
Open

Server URL with trailing / produces unexpected error #45

pinusc opened this issue Jan 23, 2023 · 0 comments · May be fixed by #46

Comments

@pinusc
Copy link

pinusc commented Jan 23, 2023

Currently, if the url parameter in the config has a trailing slash (e.g. https://music.example.com/ as opposed to https://music.example.com), then subidy is able to connect correctly and even show songs/albums/etc, but fails to stream - yielding instead a very confusing error about needing a gstreamer plugin for text/html.

The reason for this is that subidy later generates URLs with double slashes, such as https://music.example.com//rest/stream.view?id=tr-12749&c=Mopidy-Subidy&v=1.14.0&u=******&p=******, which can produce an HTML error page instead of a binary audio stream.

I made a PR to fix this, it should link to this issue.

@pinusc pinusc linked a pull request Jan 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant