You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Antoine and I have created this branch in order to update the matlab routines to the new environment (HDF5 output format). Most of the important changes required for the tools to work on the new versions of SPEC (2.0 or more) are already implemented thanks to Antoine.
I will revise and make minor modifications. Feel free to test and report bugs. Once we are convinced that we have a good working update, we will merge back into master.
The text was updated successfully, but these errors were encountered:
@zhisong and I are working on the Zernike branch and we want to update the Matlab tools before preparing the merge into the master branch. @jloizu: Maybe we should merge this matlab_update branch first, so that Zhisong and I work on the updated version of the Matlab tools.
What do you think? Do we still need to do anything on this matlab_update branch before merging into master? If yes, what? I had a few things on my list:
Test plot_spec_iota when used on free-boundary cases. Sometimes I got an error
Solve bug in plot_spec_Bgrid
Extend plot_spec_modB_boundary to slab and cylindrical geometries
Use same format in plot_spec_poincare and plot_spec_kam for the toroidal angle input
Remove fdata_from_data, gdata_from_data, idata_from_data and read directly from the hdf5 structure
Antoine and Zhisong, great work and already a first congratulations!
@abaillod Regarding the matlab tools, all the check points are very good things to do but we can do that a posteriori, so I would merge as you say the matlab branch, and then, once the zernike branch is merged into master, we can work for a day on the matlab tools to make them more complete. I don't think it is an urgency that should stop you guys from merging.
Antoine and I have created this branch in order to update the matlab routines to the new environment (HDF5 output format). Most of the important changes required for the tools to work on the new versions of SPEC (2.0 or more) are already implemented thanks to Antoine.
I will revise and make minor modifications. Feel free to test and report bugs. Once we are convinced that we have a good working update, we will merge back into master.
The text was updated successfully, but these errors were encountered: