[Bug]: Account Settings patches seem to cause hanging

[Nightkingale]

Checked Existing

• I have checked the repository for duplicate issues.

What happened?

I have not been able to use Inkay when it's set to connect to Pretendo servers. Booting up the console using coldboot Aroma (and isfshax installed) causes the console to hang either when loading the Wii U Menu or soon after. Running Aroma through Health & Safety Information tends to work briefly, but I experience a hang eventually as well.

I did some digging on my end, and reverted all patches relating to Account Settings that were added in the v2.5 release. This seemed to work, as did just using the v2.4 release.

In particular, I commented out all of the following lines in src/patches/account_settings.cpp and src/iosu_url_patches.h:

Inkay/src/patches/account_settings.cpp

Lines 125 to 133 in 349b1f3

	if (!replace(0x10000000, 0x10000000, wave_original, sizeof(wave_original), wave_new, sizeof(wave_new))) {
	DEBUG_FUNCTION_LINE("Inkay: We didn't find the url /)>~<(\\");
	return false;
	}
	if (!replace(0x10000000, 0x10000000, whitelist_original, sizeof(whitelist_original), whitelist_new, sizeof(whitelist_new))) {
	DEBUG_FUNCTION_LINE("Inkay: We didn't find the whitelist /)>~<(\\");
	return false;
	}

Inkay/src/patches/account_settings.cpp

Lines 138 to 140 in 349b1f3

	WUPS_MUST_REPLACE_FOR_PROCESS(FSOpenFile_accSettings, WUPS_LOADER_LIBRARY_COREINIT, FSOpenFile, WUPS_FP_TARGET_PROCESS_GAME);
	WUPS_MUST_REPLACE_FOR_PROCESS(FSReadFile_accSettings, WUPS_LOADER_LIBRARY_COREINIT, FSReadFile, WUPS_FP_TARGET_PROCESS_GAME);
	WUPS_MUST_REPLACE_FOR_PROCESS(FSCloseFile_accSettings, WUPS_LOADER_LIBRARY_COREINIT, FSCloseFile, WUPS_FP_TARGET_PROCESS_GAME);

Inkay/src/iosu_url_patches.h

Line 38 in 349b1f3

{0xE24B8A24, "https://nppl.app.pretendo.cc/p01/policylist/1/1/UNK"},

I'm not exactly sure which lines are causing the issue, as it seems I had to undo all of them in order to get Inkay to work. I don't know what the purpose of these patches are either beyond being used for the upcoming Account Settings stuff, but I fear they might be patching other stuff it shouldn't be as well?

What did you expect to happen?

The console should load the Wii U Menu successfully without any hanging, and I presume successfully patch Account Settings.

Steps to reproduce?

I have tried as many troubleshooting tactics as I could think of. So far, I've done the following:

• Formatted my SD card and restored all the files that were on it.
• Redownloaded completely fresh Aroma files to confirm Aroma wasn't the issue.
• Redownloaded the latest version of Inkay from the releases on this repository.
• Isolated Inkay from all other plugins so Inkay was the only plugin I had.

Other relevant information. (OPTIONAL)

I think it's important to note that I've done a lot of account-related experimentation that a typical user probably shouldn't or wouldn't do, including changing the persistent ID on my user. Without knowing how these patches work, I can't tell if this would be related.

[ashquarky]

I agree this looks like an Account Settings issue, though having to make the change to iosu_url_patches is wild - that's a tweak to BOSS/SpotPass, unrelated to this. Without that you probably won't be able to get on Splatoon.

[ashquarky]

I've stared at the code and I'm quite confused as to how the account settings patches would cause errors on the Wii U Menu. Are you able to source a crash log from /system_slc/logs?

[jonbarrow]

that's a tweak to BOSS/SpotPass, unrelated to this

The line he commented out there is for patching the policylist. This would line up with the timing of the hang, as the policylist is damn near the first thing the console tries to request during boot. Though like you said, that line is unrelated to the account settings changes...

It sounds like he's having a crash at the same point I was when we were testing out your Hokaku changes, which was caused by us using different firmware versions. I wonder if this is similar..? Though if the same patches work in 2.4.0 I'm not sure why they'd break in 2.5.0...

[Nightkingale]

Are you able to source a crash log from /system_slc/logs?

This is the first place I looked for more information before coming here. Unfortunately, the hanging doesn't produce a crash log. I just now replicated the issue where this time it hung on the "Signing in to Nintendo Network..." message, however my latest crash log is from a few days ago (which was unrelated, Inkay was not present). I'm wondering if it's not actually crashing, just... stuck?

Again, I do want to emphasize the fact that I have done user and account-related tinkering, upwards of changing a user's persistent ID. I think it's very possible it's just something I did on my end which Inkay doesn't play nice with.

If there's another way you suggest me try and get logs or more information I could probably provide, let me know.

[Nightkingale]

Hey again! Just wanted to pop in and confirm that the issue is still present for me on Inkay v2.6.0. I bought a serial logging cable to see if I could get anything useful out of it, and I wrote a few logs.

• The first is from when launching Aroma manually through Health & Safety Information, which then proceeds to hang on "Signing in to Nintendo Network..."
• The second is an Aroma coldboot, which hangs when trying to load Wii U Menu.

When looking through both though, I honestly don't see how Inkay would be related to this issue. I am wondering if it's an Aroma issue and it's causing Inkay to not want to play nice with my system?

inkay_troubleshooting_1.log (warmboot)
inkay_troubleshooting_2.log (coldboot)

[ashquarky]

Have you rebuilt MLC on this console at all? Other users were seeing strange issues resulting from rebuilding a 5.5.x console into a 5.5.5+ one; since the rebuild doesn't upgrade OSv10.

[Nightkingale]

Nope, have not rebuilt MLC on this console. Interesting to note though!