missing CSS class for InPost integration

[kkolcon]

Hello,

I've noticed a problem with InPost free module - when module is installed and configured, map with Paczkomaty (Parcel Lockers) doesn't open in the shipping step.

The problem is caused by missing CSS class "carrier-extra-content" in file hummingbird/templates/checkout/_partials/steps/shipping.tpl, in line 61. This CSS class is used as a reference in the module code.
Here's how this part should look like (starting from line 60):

<div class="carrier__extra-content-wrapper {if $delivery_option == $carrier_id} carrier__extra-content-wrapper--active {/if} js-carrier-extra-content" {if $delivery_option !== $carrier_id}style="max-height:0px"{/if}>
   <div class="carrier__extra-content carrier-extra-content">
      {$carrier.extraContent nofilter}
   </div>
</div>

[SharakPL]

One more example of BEM breaking things 😜

[kpodemski]

Hello @kkolcon

It's this Inpost module that has to adapt to Hummingbird.

ping @Oksydan

[Oksydan]

Hi @kkolcon,

I'm not sure if we should be concerned about this right now 🤔.
You can send this information to InPost support and we can look into it, but I'd like to wait for the official stable version of the Hummingbird theme.

[kkolcon]

Hi,

I've already informed InPost and sent them my solution as well.
I just thought someone who use Hummingbird may come upon this problem, so I've written about it to reduce their debugging time 😀

[SharakPL]

It's this Inpost module that has to adapt to Hummingbird.

I don't get why we have to use BEM. I'm also pretty sure it won't be the only module with problems like that. Many of them refer to classes used typically on PS themes and they won't work on hummingbrid because standard-css-class was changed to standard--css__class. BEM is useless here!

Anyway, the fix is quite simple (add missing non-BEM class) so it should be fixed here.

[Hlavtox]

@SharakPL BEM has nothing to do with some module relying on a class.

[SharakPL]

Sure, but completely unnecessary switch to BEM is the reason those modules don't work with Hummingbird.