Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Shopping cart - If you check the Customized button, there's a warning #612

Open
florine2623 opened this issue Mar 22, 2024 · 6 comments
Labels
Discussion A question was raised

Comments

@florine2623
Copy link

florine2623 commented Mar 22, 2024

Describe the bug and add attachments

When I add a customization to a product, if I check the customization in the Shopping cart, I have a warning :
Screenshot 2024-03-22 at 16 00 22

getimagesize(http://develop:8888/en/upload/86cae4ab669495998bcc14d5974e0b6e): Failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in /Users/fHea/Desktop/develop/var/cache/dev/smarty/compile/hummingbirdlayouts_layout_full_width_tpl/70/12/42/7012426849de68e689ac7f8cab09d2eb050ff3e3_2.file.product-customization-modal.tpl.php on line 96

Expected behavior

Should look like the modal in the details order page :
Screenshot 2024-03-22 at 16 08 44

Steps to reproduce

  1. Go to BO > Create a product with a customization
  2. Go to FO > Add product with custom to cart
  3. Click on "Customized" button
  4. SeeWarning ❌

PrestaShop version(s) where the bug happened

9.0.0

PHP version(s) where the bug happened

8.1

@tblivet
Copy link
Contributor

tblivet commented May 21, 2024

Hello @nicosomb 👋

I'm able to reproduce the issue, but I believe we cannot fix it without editing the core. The warning appears in debug mode when the .tpl file tries to get the image size dimensions to display it in a modal.

This functionality wasn't implemented in the classic theme, so maybe this feature can be postponed for later?

@nicosomb
Copy link
Contributor

@amine-O what's your opinion about this issue?

@amine-O
Copy link

amine-O commented May 23, 2024

If it's not implemented on Classic, I don't see the emergency of doing it now
@tblivet are you able to reproduce it also on the Classic theme ?

@tblivet
Copy link
Contributor

tblivet commented May 23, 2024

@amine-O In the Classic theme, we don't have this warning because the element that throws the warning is only introduced in Hummingbird.

@amine-O
Copy link

amine-O commented May 23, 2024

Ok let's postpone it then, we'll see if it's needed later

@Hlavtox
Copy link
Contributor

Hlavtox commented May 23, 2024

No getimagesize call should be in the template, theme should be just the view. If some more info is needed, we should provide it from the core. 👍

@tblivet tblivet added the Discussion A question was raised label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion A question was raised
Projects
None yet
Development

No branches or pull requests

5 participants