Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add "~" in these modules_to_hook? #415

Open
rodriciru opened this issue Dec 21, 2022 · 3 comments
Open

Should we add "~" in these modules_to_hook? #415

rodriciru opened this issue Dec 21, 2022 · 3 comments
Labels
Discussion A question was raised

Comments

@rodriciru
Copy link
Contributor

displayCustomerAccount:

displayMyAccountBlock:

displayProductAdditionalInfo:

Now, when switching themes, all modules hooked into that hooks, will be unhooked from that position, and will remain only the modules in this listed in this file.
Adding "- ~" at the end or beginning, will ensure that other modules will stay (for example gpdr, and email alerts)

@SharakPL
Copy link
Contributor

Would be best if whole process of switching the theme could be monitored. Now it's just long loading with alert at the end. Should be a progress bar and a log like you get from 1-click-upgrade or when you import data with CSV.

Module X disabled
Module Y enabled
Module Z v.1.2.3 installed from Prestashop Add-ons

Plus a prompt at the end when there are conflicts:

Looks like new theme doesn't require these modules used by previous theme. What do you want to do with theme?

Module A v.1.2.3 : Keep Disable Uninstall
Module B v.4.2.1 : Keep Disable Uninstall

@rodriciru
Copy link
Contributor Author

That's looks superb, but I assume it involves core changes, and this is slow.
Why not, for the moment, think about these changes? They are faster and don't break any current setup (at least in these hooks)
Happy holidays!

@NeOMakinG
Copy link
Contributor

I would say why not, wdyt @Hlavtox ?

@tblivet tblivet added the Discussion A question was raised label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion A question was raised
Projects
None yet
Development

No branches or pull requests

4 participants