Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate trace context to triggered deployments from within parent run #16364

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

jeanluciano
Copy link
Contributor

@jeanluciano jeanluciano commented Dec 12, 2024

This PR adds labels field to create_flow_run_from_deployment in order to be able to pass parent OTEL trace labels to child flow runs created by create_flow_run_from_deployment

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

jeanluciano and others added 26 commits November 26, 2024 11:16
…/cloud-740-update-flow-run-instrumentation-to-use-runtelemetry-class
…untelemetry-class' of https://github.com/PrefectHQ/prefect into jean/cloud-740-update-flow-run-instrumentation-to-use-runtelemetry-class
…untelemetry-class' of https://github.com/PrefectHQ/prefect into jean/cloud-740-update-flow-run-instrumentation-to-use-runtelemetry-class
@github-actions github-actions bot added the docs label Dec 12, 2024
@jeanluciano jeanluciano changed the title Propagate trace context to triggered deployments from within parent run. WIP:Propagate trace context to triggered deployments from within parent run. Dec 12, 2024
Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #16364 will not alter performance

Comparing jean/cloud-696-propagate-trace-context-to-triggered-deployments-from-within (ad3303f) with main (40590a5)

Summary

✅ 3 untouched benchmarks

…loyments-from-within' of https://github.com/PrefectHQ/prefect into jean/cloud-696-propagate-trace-context-to-triggered-deployments-from-within
@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Dec 13, 2024
@jeanluciano jeanluciano changed the title WIP:Propagate trace context to triggered deployments from within parent run. Propagate trace context to triggered deployments from within parent run. Dec 13, 2024
@jeanluciano jeanluciano changed the title Propagate trace context to triggered deployments from within parent run. Propagate trace context to triggered deployments from within parent run Dec 13, 2024
@jeanluciano jeanluciano marked this pull request as ready for review December 13, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants