Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffer to type completeness check #16361

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Dec 12, 2024

This PR adds a buffer to the type completeness and lets contributors know to contact @zzstoatzz or me if they run into typing issues.

Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #16361 will not alter performance

Comparing improve-type-check-workflow (599d86a) with main (dce8eca)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle changed the title Improve guidance when type completeness check fails Add buffer to type completeness check Dec 12, 2024
@desertaxle desertaxle marked this pull request as ready for review December 12, 2024 17:37
@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Dec 12, 2024
@zzstoatzz zzstoatzz merged commit 4f7f7bb into main Dec 12, 2024
14 checks passed
@zzstoatzz zzstoatzz deleted the improve-type-check-workflow branch December 12, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants