Temporarily disable passing worker labels to flow run #16339
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily removes
_give_worker_labels_to_flow_run
from the worker's submission loop.This method uses the
CloudClient.update_flow_run_labels
. TheCloudClient
does not have all the specialhttpx_settings
and custom transport setup that we instantiate in the constructor ofPrefectClient
. This can potentially lead to instability and can lead tohttpx.ConnectTimeout
errors (and others) when theCloudClient
is used in something like theWorker
that will need to make a lot of requests. Previously theCloudClient
was only for things like 1 of CLI commands.The
_give_worker_labels_to_flow_run
method can be added back to the worker's submission loop whenupdate_flow_run_labels
is moved over toPrefectClient
(which is blocked by https://github.com/PrefectHQ/prefect/pull/16233/files, but to my understanding is going to happen soon). For now it is non critical to have this in place and will hopefully lead to less errors during flow run submission.Long term we might need consolidate creating our
httpx_settings
if theCloudClient
is going to be used in higher request volume scenarios like orchestration (happy to do this in another pr, but didn't want to jump the gun as it seems the method is going to be moved over to the other client already).