[typing] prefect.tasks and prefect.task_worker
#16332
Open
+159
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development
CodSpeed Performance ReportMerging #16332 will not alter performanceComparing Summary
|
zzstoatzz
force-pushed
the
fix-some-task-worker-typing
branch
3 times, most recently
from
1e13b8e to
e04574a
Compare
whaaaa thank you fix secret block description
zzstoatzz
force-pushed
the
fix-some-task-worker-typing
branch
from
e04574a to
dd4340d
Compare
mjpieters
suggested changes
Dec 11, 2024
| @@ -362,7 +388,7 @@ async def __aenter__(self): | |||
| self._started_at = pendulum.now() | |||
| return self | |||
|
|
|||
| async def __aexit__(self, *exc_info): | |||
| async def __aexit__(self, *exc_info: Any): | |||
There was a problem hiding this comment.
You forgot the return annotation 😀
Suggested change
| async def __aexit__(self, *exc_info: Any): | |
| async def __aexit__(self, *exc_info: Any) -> Optional[bool] |
Or just None or bool as applicable.
There was a problem hiding this comment.
sorry, maybe I'm missing your point but this __aexit__ doesn't return
hide isinstance
zzstoatzz
force-pushed
the
fix-some-task-worker-typing
branch
from
3f3c464 to
199a165
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #16292
fixes a circular import problem related to imports of
Taskinasync_dispatchsome assorted other fixes to pass the check