Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes for docstrings for when functionality was added #16094

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

discdiver
Copy link
Contributor

@discdiver discdiver commented Nov 22, 2024

Because we aren't creating separate docs versions, we want to add information about when functionality was added, as the Python docs do.

Pre-commit passes locally.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #16094 will not alter performance

Comparing calling (34a180e) with main (340e296)

Summary

✅ 3 untouched benchmarks

@discdiver discdiver marked this pull request as ready for review November 22, 2024 19:39
Copy link
Collaborator

@zzstoatzz zzstoatzz Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes don't all seem related to the docstring, it looks like its undoing the formatting changes we merged the other day

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the formatting is being changed. This was auto-generated as part of a pre-commit hook. Any ideas how to resolve?

Copy link
Contributor

github-actions bot commented Dec 6, 2024

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants