You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, sendTo in NotificationDetails will use a random value from props.data for most BlockType, it will cause inconsistecy in different deploy of prefect server instances.
In my PR PrefectHQ/prefect#9547 , which add a CustomWebhookNotificationBlock, both name and url can becomes the value displayed at sendTo depends on database type(postgresql jsonb type will not keep key order of object, which may be the root cause).
Using sqlite:
Using postgresql:
I think it's better to use something like this, so the value source of sendTo is stable:
// try name, url in order, or blockName is non exists.value: asArray(props.data.name||props.data.url||props.blockType.name),
Or, still use Object.values(props.data)[0] in place of props.blockType.name for backword compatibility.
The text was updated successfully, but these errors were encountered:
prefect-ui-library/src/components/NotificationDetails.vue
Lines 59 to 63 in 5ebb049
Currently,
sendTo
in NotificationDetails will use a random value fromprops.data
for most BlockType, it will cause inconsistecy in different deploy of prefect server instances.In my PR PrefectHQ/prefect#9547 , which add a CustomWebhookNotificationBlock, both
name
andurl
can becomes the value displayed atsendTo
depends on database type(postgresql jsonb type will not keep key order of object, which may be the root cause).Using sqlite:
Using postgresql:
I think it's better to use something like this, so the value source of
sendTo
is stable:Or, still use
Object.values(props.data)[0]
in place ofprops.blockType.name
for backword compatibility.The text was updated successfully, but these errors were encountered: