Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Wcostream): update display domain name #8912

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

Espressocodes
Copy link
Contributor

@Espressocodes Espressocodes commented Nov 25, 2024

Description

Updated:

  • Domain to .tv
  • version number this time

Will change fork name next time to reflect proper naming convention. Never done this before.

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

Original Edits
Immense help from crunchy I have no idea what I'm doing.

@Espressocodes
Copy link
Contributor Author

As per @veryCrunchy;

  • Updated version number to comply

Updated formatting for modification from fork to comply with standards.

@Espressocodes Espressocodes changed the title Wcostream domain 2 Fix(Wcostream): Domain Nov 25, 2024
@darkvillager2
Copy link
Contributor

@Espressocodes provide proof that the made changes actually work with the presence.

@veryCrunchy
Copy link
Member

veryCrunchy commented Nov 26, 2024

@Espressocodes provide proof that the made changes actually work with the presence.

The change doesn't affect the presence. It only updates the url displayed on the presence store.

@Espressocodes
Copy link
Contributor Author

@veryCrunchy when you get some time would you look through the presence and see if it needs any updates to function with a new internal domain in the presence itself? And then subsequently help me step by step fix it if so, because you and I both know I have absolutely no idea how I would do that?

It should be said with how many hosts they have the alt domains should probably be tested on the presence at some point since the main one is down 99.9% of the time.

@darkvillager2
Copy link
Contributor

@Espressocodes provide proof that the made changes actually work with the presence.

The change doesn't affect the presence. It only updates the url displayed on the presence store.

Still, the site could be changed under the hood. So they must provide proof

@veryCrunchy
Copy link
Member

Still, the site could be changed under the hood. So they must provide proof

We usually don't ask for proof of the presence working for these kind of changes. This change doesn't affect how the presence functions. It only reflects the .com domain now redirecting to .tv.

@theusaf theusaf changed the title Fix(Wcostream): Domain refactor(Wcostream): update display domain name Nov 26, 2024
@theusaf theusaf enabled auto-merge (squash) November 26, 2024 22:21
@theusaf theusaf requested a review from Bas950 November 26, 2024 22:21
@Espressocodes
Copy link
Contributor Author

Thank you for the title formatting fix. I tried.

@theusaf theusaf merged commit a2d1576 into PreMiD:main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants