-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Wcostream): update display domain name #8912
Conversation
Signed-off-by: Jamie Needham <[email protected]>
As per @veryCrunchy;
Updated formatting for modification from fork to comply with standards. |
@Espressocodes provide proof that the made changes actually work with the presence. |
The change doesn't affect the presence. It only updates the url displayed on the presence store. |
@veryCrunchy when you get some time would you look through the presence and see if it needs any updates to function with a new internal domain in the presence itself? And then subsequently help me step by step fix it if so, because you and I both know I have absolutely no idea how I would do that? It should be said with how many hosts they have the alt domains should probably be tested on the presence at some point since the main one is down 99.9% of the time. |
Still, the site could be changed under the hood. So they must provide proof |
We usually don't ask for proof of the presence working for these kind of changes. This change doesn't affect how the presence functions. It only reflects the .com domain now redirecting to .tv. |
Thank you for the title formatting fix. I tried. |
Description
Updated:
Will change fork name next time to reflect proper naming convention. Never done this before.
Acknowledgements
yarn format
Screenshots
Proof showing the creation/modification is working as expected
Immense help from crunchy I have no idea what I'm doing.