Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Gemini): added option to show title #8887

Merged
merged 10 commits into from
Nov 16, 2024
Merged

Conversation

tschogge
Copy link
Contributor

Description

feat(gemini): added option to show title

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected When show title is activated

image

When show title is deactivated

image

@Bas950 Bas950 changed the title Gemini fix feat(gemini): added option to show title Nov 13, 2024
@Bas950 Bas950 changed the title feat(gemini): added option to show title feat(Gemini): added option to show title Nov 13, 2024
@Bas950 Bas950 requested a review from theusaf November 13, 2024 10:10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes to this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

Comment on lines 31 to 34
// eslint-disable-next-line no-one-time-vars/no-one-time-vars
askedWOrds = elem[0].textContent.split(" ").length,
// eslint-disable-next-line no-one-time-vars/no-one-time-vars
answerWords = elem[1].textContent.split(" ").length;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless required, do not disable eslint rules

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay resolved it

@theusaf theusaf requested a review from Bas950 November 15, 2024 19:17
@theusaf theusaf enabled auto-merge (squash) November 15, 2024 19:17
@theusaf theusaf merged commit 1359f44 into PreMiD:main Nov 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants