Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(YNOProject): add Presence #8879

Merged
merged 14 commits into from
Nov 15, 2024
Merged

feat(YNOProject): add Presence #8879

merged 14 commits into from
Nov 15, 2024
+247 −0

Conversation

luo3house
Copy link
Contributor

Description

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected Screenshot 2024-11-10 at 12 27 25 Screenshot 2024-11-10 at 12 30 22 Screenshot 2024-11-10 at 12 31 28 Screenshot 2024-11-10 at 12 32 11 Screenshot 2024-11-10 at 12 32 57 Screenshot 2024-11-10 at 12 35 18 Screenshot 2024-11-10 at 12 45 39

darkvillager2
darkvillager2 approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@darkvillager2 darkvillager2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luo3house
Copy link
Contributor Author

Screenshot 2024-11-11 at 22 27 01 Screenshot 2024-11-11 at 22 19 58
See more Screenshot 2024-11-11 at 22 23 21 Screenshot 2024-11-11 at 22 29 09 Screenshot 2024-11-11 at 22 26 13 Screenshot 2024-11-11 at 22 24 48 Screenshot 2024-11-11 at 22 23 50 Screenshot 2024-11-11 at 22 18 15

theusaf
theusaf requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@theusaf theusaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, just a couple of stylistic things to fix to be consistent with other presence's quality and readability.

websites/Y/YNOProject/presence.ts Outdated Show resolved Hide resolved
websites/Y/YNOProject/presence.ts Outdated Show resolved Hide resolved
websites/Y/YNOProject/presence.ts Outdated Show resolved Hide resolved
websites/Y/YNOProject/presence.ts Outdated Show resolved Hide resolved
websites/Y/YNOProject/presence.ts Outdated Show resolved Hide resolved
@luo3house
Copy link
Contributor Author

Thanks for typo suggestions

@luo3house
Copy link
Contributor Author

luo3house commented Nov 12, 2024 •
edited
Loading

Screenshot 2024-11-12 at 10 23 56

@theusaf theusaf enabled auto-merge (squash) November 13, 2024 16:31
@theusaf theusaf requested a review from Bas950 November 13, 2024 16:31
Bas950
Bas950 requested changes Nov 13, 2024
View reviewed changes
websites/Y/YNOProject/metadata.json Outdated Show resolved Hide resolved
@luo3house @Bas950
Update websites/Y/YNOProject/metadata.json
4494e26 
Co-authored-by: Bas van Zanten <[email protected]>
Signed-off-by: Zenn Laurence <[email protected]>
auto-merge was automatically disabled November 13, 2024 23:47

Head branch was pushed to by a user without write access

@luo3house
Copy link
Contributor Author

draw glitches occurs while performing animated actions cuz blobs of animation frame inquired were quickly got gc
Screenshot 2024-11-14 at 14 03 21

@theusaf theusaf merged commit f4cd253 into PreMiD:main Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkvillager2 darkvillager2 darkvillager2 approved these changes

@Bas950 Bas950 Bas950 approved these changes

@theusaf theusaf theusaf approved these changes

Assignees
No one assigned
Labels
new presence
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luo3house @theusaf @Bas950 @darkvillager2