Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation Full Frame #110

Closed
sarojpanda44 opened this issue Nov 11, 2024 · 7 comments
Closed

Animation Full Frame #110

sarojpanda44 opened this issue Nov 11, 2024 · 7 comments
Labels
next release Issues that will be included in the next planned release.

Comments

@sarojpanda44
Copy link

UI/UX Issue

The cloud animation doesn't fill up the full top frame. It looks better with full frame animation like in Google weather forecast. Screenshots attached. Thanks 👍

Screenshot_20241111-214753
Screenshot_20241111-214835

Additional Context

Any additional context, such as suggestions for improvement.

@PranshulGG
Copy link
Owner

PranshulGG commented Nov 12, 2024

The animation is gonna get cut off at the status bar anyway, which doesn’t look great. Also, the animation I’m using isn’t really big enough to fill up the card and top header, but I'm thinking to make the app edge to edge so yea I might consider.

@sarojpanda44
Copy link
Author

Not sure if edge to edge is required. But it is more about animations being in the backgroud of the search box, instead of starting from below.

@PranshulGG
Copy link
Owner

The reason is the top ‘search bar’ and bottom card are two different elements, so I can’t overlay the animation. Like, in Google’s, when you scroll down, the search bar doesn’t stick to the top ‘cause it’s the same element. But in mine, it does stick, so I’d have to remake the whole main card and search bar to make it work.

@PranshulGG PranshulGG added future release Issues that will be addressed in a later release cycle. rework needed Requires significant changes or improvements before completion. labels Nov 12, 2024
@sarojpanda44
Copy link
Author

sarojpanda44 commented Nov 12, 2024

Understood. Trading off with one or the other features 😄
But keep in mind if it's possible in any way then it would be amazing 😊

@PranshulGG
Copy link
Owner

Understood. Trading off with one or the other features 😄 But keep in mind if it's possible in any way then it would be amazing 😊

If it’s easy to implement, you might see it in the next update

@PranshulGG PranshulGG changed the title Weather animation Animation Full Frame Nov 12, 2024
@PranshulGG PranshulGG added next release Issues that will be included in the next planned release. and removed future release Issues that will be addressed in a later release cycle. rework needed Requires significant changes or improvements before completion. labels Dec 23, 2024
@PranshulGG
Copy link
Owner

@sarojpanda44 I know it's late, lol, but I managed to make the animation full-frame! I had to recode how animations are placed on the card.

@PranshulGG PranshulGG pinned this issue Dec 23, 2024
@sarojpanda44
Copy link
Author

Awesome 😍

@PranshulGG PranshulGG unpinned this issue Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Issues that will be included in the next planned release.
Projects
None yet
Development

No branches or pull requests

2 participants