Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve action rules #1156

Merged
merged 62 commits into from
Sep 21, 2023
Merged

Improve action rules #1156

merged 62 commits into from
Sep 21, 2023

Conversation

luanfreitasdev
Copy link
Collaborator

@luanfreitasdev luanfreitasdev commented Sep 17, 2023

⚡ PowerGrid - Pull Request

Welcome and thank you for your interest in contributing to our project!. You must use this template to submit a Pull Request or it will not be accepted.


Motivation

  • Bug fix
  • Enhancement
  • New feature
  • Breaking change

Bugfix

  • Improved reading of action rules
  • Allows you to add several rules for Rule::checkbox, rows, and radio.

New Feature

  • Add $this->showRadioButton(), similar to showCheckbox but using radio. Only one is allowed:

Enhancement

  • Add tests with Cypress for action rules
  • Separate the pipelines
  • Blade refactoring allows better reading. This allowed us to use the feature detail together with inject_morph_markers.

Related Issue(s): #_____.

Documentation

This PR requires Documentation update?

  • Yes
  • No
  • I have already submitted a Documentation pull request.

@luanfreitasdev luanfreitasdev marked this pull request as ready for review September 20, 2023 21:50
luanfreitasdev and others added 5 commits September 20, 2023 18:54
* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* pipeline

* pipeline

* pipeline

* wip

* wip

* add cypress tests to radio rules

* add cypress tests to checkbox, radio, rows

* fix loop

* fix checkbox

* fix phpstan

* fix tests
@luanfreitasdev luanfreitasdev merged commit 1694091 into 5.x Sep 21, 2023
18 checks passed
@luanfreitasdev luanfreitasdev deleted the improve-action-rules branch September 21, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant