Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated remote config to include domain restrictions #26875

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 12, 2024

Problem

We need a way to do some level of dynamic config checking

Changes

  • There is only one cached config entry now - the others are built in memory from that as they dont need other api calls
  • Checks the domain like before and sets the appropriate vary headers
  • Add tests to ensure the api works as expected
  • Validate the CDN caches based on vary header

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite marked this pull request as ready for review December 12, 2024 17:27
@benjackwhite benjackwhite requested a review from a team December 12, 2024 17:39
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little thinking out loud but 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants