refactor: Extract functions to parent #26584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions will be reused in `stats_table.py`, so it makes sense to extract them one level higher. There's some extra complication on how we handle `self.query.compare` because `stats_table.py` always wants to compare.
|
|
@robbie-c It's not complicating me right now, but I'm always happy to remove code :) |
|
I was just looking at the mypy errors ;) |
@robbie-c Oh, duh :). Might remove it then, thx |
This isnt being used anymore, and it's just complicating some of our code changes
This is complicated because `self.query` doesn't always have `self.query.compare`, so this would fail a lot of tests
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
rafaeelaudibert
commented
Dec 2, 2024
There was a problem hiding this comment.
Ahn, looks very wrong, hog is gone 🔥, I will make it regenerate this once Depot is back online
rafaeelaudibert
force-pushed
the
display-stats-from-conversion-goals-only
branch
from
bdcbb72 to
cbcb8a9
Compare
|
@robbie-c tests are passing now :) |
robbie-c
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions will be reused in
stats_table.py, so it makes sense to extract them one level higher. There's some extra complication on how we handleself.query.comparebecausestats_table.pyalways wants to compare, so we need that to be a parameterThis is just refactoring work to allow us to better filter by
ConversionGoalonstats_table.py. If anything, this is just better code (to some definition of better)