feat(temporal): Added posthog client to temporal to enable exceptions capture #26583
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDsCODE
approved these changes
Dec 3, 2024
tomasfarias
reviewed
Dec 3, 2024
|
|
||
| workflow_result = await super().execute_workflow(input) | ||
|
|
||
| ph_client.flush() |
There was a problem hiding this comment.
Is this call blocking? Should we send it to a thread with asyncio.to_thread?
tomasfarias
reviewed
Dec 3, 2024
|
|
||
| class _PostHogClientWorkflowInterceptor(WorkflowInboundInterceptor): | ||
| async def execute_workflow(self, input: ExecuteWorkflowInput) -> Any: | ||
| ph_client = Client(api_key="sTMFPsFhdP1Ssg", enable_exception_autocapture=True) |
There was a problem hiding this comment.
Out of curiosity, is this api key public?
tomasfarias
reviewed
Dec 3, 2024
| async def execute_workflow(self, input: ExecuteWorkflowInput) -> Any: | ||
| ph_client = Client(api_key="sTMFPsFhdP1Ssg", enable_exception_autocapture=True) | ||
|
|
||
| workflow_result = await super().execute_workflow(input) |
There was a problem hiding this comment.
Shouldn't we wrap this call in a try, except? Otherwise we won't be calling ph_client.flush() if anything is raised.
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes