feat(cdp): site destinations #26572
Merged
feat(cdp): site destinations #26572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +141 B (+0.01%) Total Size: 1.11 MB ℹ️ View Unchanged
|
benjackwhite
requested changes
Dec 2, 2024
|
Done, flag added |
benjackwhite
approved these changes
Dec 3, 2024
| "label": "Additional properties", | ||
| "description": "Additional properties for the Exported Object.", | ||
| "default": { | ||
| "email": "{person.properties.email}", |
There was a problem hiding this comment.
Person properties wont be available client side right?
There was a problem hiding this comment.
The ones you have provided to posthog-js will be
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
mariusandra
force-pushed
the
site-destinations
branch
from
a63dc1b to
ae454c5
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Splitting #26169 in two: site destinations & new site apps
Changes
This is the site destinations part:
Plus some more changes:
/decidefor teams with site apps enabled to load new hog-function-site-apps/destinations. We're moving to something more static soon anyway.How did you test this code?
Added a bunch of tests