Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toolbar event debugger #26561

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Nov 30, 2024

Got some feeback from a user that this confused them

It's pretty raw

Let's make it slightly less so

2024-11-30 17 59 02

)
}

ToolbarMenu.Footer = function ToolbarMenufooter({ children, className }: ToolbarMenuProps): JSX.Element {
return <div className={clsx('flex flex-row items-center p-2 border-t gap-2', className)}>{children}</div>
ToolbarMenu.Footer = function ToolbarMenufooter({ children, className, noPadding }: ToolbarMenuProps): JSX.Element {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only needed no padding in this component i think
but felt weird for it to not be an option throughout

Copy link
Contributor

github-actions bot commented Nov 30, 2024

Size Change: -52.5 kB (-4.53%) ✅

Total Size: 1.11 MB

Filename Size Change
frontend/dist/toolbar.js 1.11 MB -52.5 kB (-4.53%)

compressed-size-action

@pauldambra pauldambra marked this pull request as ready for review November 30, 2024 18:21
@pauldambra pauldambra requested a review from a team November 30, 2024 18:21
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

14 snapshot changes in total. 0 added, 14 modified, 0 deleted:

  • chromium: 0 added, 14 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants