feat(experiments): Add input field for editing selector #26487
Conversation
|
Size Change: +402 B (+0.03%) Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
| @@ -131,6 +132,12 @@ export const experimentsTabLogic = kea<experimentsTabLogicType>([ | |||
| hideButtonExperiments: () => false, | |||
| }, | |||
| ], | |||
| editSelectorShowing: [ | |||
There was a problem hiding this comment.
Nit: If we have a state value that's only used locally within a single element, especially a toggle or boolean value, I strongly prefer using local state instead of a Kea value. In WebExperimentTransformField.tsx, we already do this with [transformSelected, setTransformSelected].
While we always aim to separate state from React components, I think this is the one exception. It simplifies working with the value since it only requires a single line of code, and you don't have to update two separate files.
There was a problem hiding this comment.
Sounds good, updated in 98d0eec
Changes
Adds an input field for editing the selector associated with a web experiment transform. This lets the user be more specific with the behavior they'd like.
From https://posthoghelp.zendesk.com/agent/tickets/20916
How did you test this code?
I verified I could edit the selector, and that the selector saved as expected and was applied after I refreshed the page.