Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surveys): optional questions for multipleq #17830

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Oct 5, 2023

Problem

Multiple questions should support optional questions

To go in with PostHog/posthog-js#826

Changes

Screen Shot 2023-10-05 at 5 58 10 PM

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@neilkakkar
Copy link
Collaborator

With the way things stand, optional doesn't really make sense with the link type question, does it, since there's no way to skip it even if its optional

@liyiy
Copy link
Contributor Author

liyiy commented Oct 6, 2023

With the way things stand, optional doesn't really make sense with the link type question, does it, since there's no way to skip it even if its optional

We can put in a "skip" or "next" button in the site app so users don't HAVE to click on the link but it doesn't seem that big of a deal 👀 since users have to click on a button to go next either way, and the link doesn't hurt from being opened. Alternatively, I can also remove the checkbox from link type questions if you think that makes a lot more sense.

@neilkakkar
Copy link
Collaborator

no strong opinions about it, however you feel works best is good, just wanted to make sure you've thought about it 👍

@liyiy liyiy merged commit 6d455aa into master Oct 10, 2023
72 checks passed
@liyiy liyiy deleted the surveys/optional-questions branch October 10, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants