Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redirect users to the supportModal when implementation errors occur #921

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

MarconLP
Copy link
Member

@MarconLP MarconLP commented Dec 6, 2023

redirect users to the supportModal when implementation errors occur

Copy link

github-actions bot commented Dec 6, 2023

Size Change: +200 B (0%)

Total Size: 745 kB

Filename Size Change
dist/array.full.js 176 kB +50 B (0%)
dist/array.js 118 kB +50 B (0%)
dist/es.js 118 kB +50 B (0%)
dist/module.js 118 kB +50 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder-v2.js 104 kB
dist/recorder.js 58.4 kB
dist/surveys.js 41.5 kB

compressed-size-action

@MarconLP MarconLP changed the title redirect users to the supportModal when implementation errors occur chore: redirect users to the supportModal when implementation errors occur Dec 6, 2023
@@ -181,7 +181,7 @@ export const _safewrap = function <F extends (...args: any[]) => any = (...args:
// @ts-ignore
return f.apply(this, args)
} catch (e) {
logger.critical('Implementation error. Please turn on debug and contact support@posthog.com.')
logger.critical('Implementation error. Please turn on debug mode and open a ticket on https://app.posthog.com/home#panel=support%3Asupport%3A.')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we not change this to a link and just say 'open a support ticket`?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK There is no way you can make an HTML tag interpreted by your the terminal, because your terminal has no ideas what html is. source

@mariusandra mariusandra added the bump patch Bump patch version when this PR gets merged label Dec 7, 2023
@MarconLP MarconLP merged commit 1a6dc92 into master Dec 7, 2023
14 checks passed
@MarconLP MarconLP deleted the redirect-to-supportModal-instead-of-email branch December 7, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants