Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Window or document access across the code #894

Merged
merged 6 commits into from
Nov 15, 2023

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Nov 15, 2023

Changes

Related to #547 trying to see if we can get the SDK working in service workers nicely.

Direct window/document access is no longer allowed and it is correctly typed now so we have to handle it being undefined

Checklist

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Nov 15, 2023
Copy link

github-actions bot commented Nov 15, 2023

Size Change: +1.86 kB (0%)

Total Size: 739 kB

Filename Size Change
dist/array.full.js 175 kB +532 B (0%)
dist/array.js 117 kB +412 B (0%)
dist/es.js 117 kB +412 B (0%)
dist/exception-autocapture.js 12 kB +40 B (0%)
dist/module.js 117 kB +412 B (0%)
dist/recorder-v2.js 104 kB +28 B (0%)
dist/recorder.js 58.4 kB +98 B (0%)
dist/surveys.js 39.9 kB -71 B (0%)

compressed-size-action

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@benjackwhite benjackwhite added bump minor Bump minor version when this PR gets merged and removed bump patch Bump patch version when this PR gets merged labels Nov 15, 2023
@benjackwhite benjackwhite marked this pull request as ready for review November 15, 2023 10:31
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test pass so 🤞 🚀 :shipit:

src/posthog-core.ts Show resolved Hide resolved
src/utils/globals.ts Show resolved Hide resolved
@benjackwhite benjackwhite merged commit 62c96e7 into master Nov 15, 2023
12 checks passed
@benjackwhite benjackwhite deleted the fix/window-access branch November 15, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants