Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): prioritize question button text field and thank you countdown is not automatic #893

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Nov 14, 2023

Changes

Prioritize question button text field in favor of appearance's submit button

PostHog/posthog#18623

Checklist

Copy link

github-actions bot commented Nov 14, 2023

Size Change: +98 B (0%)

Total Size: 733 kB

Filename Size Change
dist/surveys.js 39.9 kB +98 B (0%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 174 kB
dist/array.js 115 kB
dist/es.js 115 kB
dist/exception-autocapture.js 12 kB
dist/module.js 115 kB
dist/recorder-v2.js 104 kB
dist/recorder.js 58.3 kB

compressed-size-action

@liyiy liyiy added the bump minor Bump minor version when this PR gets merged label Nov 14, 2023
@liyiy liyiy changed the title fix(surveys): prioritize question button text field fix(surveys): prioritize question button text field and thank you countdown is not automatic Nov 14, 2023
submitButtonText?: string
descriptionTextColor?: string
ratingButtonColor?: string
ratingButtonActiveColor?: string
ratingButtonHoverColor?: string
whiteLabel?: boolean
autoDisappear?: boolean
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making the countdown for thank you messages optional

@liyiy liyiy merged commit c64cc35 into master Nov 15, 2023
14 checks passed
@liyiy liyiy deleted the surveysQuestionButtonText branch November 15, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant