Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(surveys): Optional survey questions #826

Merged
merged 5 commits into from
Oct 10, 2023
Merged

feat(surveys): Optional survey questions #826

merged 5 commits into from
Oct 10, 2023

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Oct 5, 2023

Changes

Adds support for optional survey questions. To go in with PostHog/posthog#17830

Screen.Recording.2023-10-05.at.3.43.38.PM.mov

Checklist

@liyiy liyiy requested a review from neilkakkar October 5, 2023 21:56
@liyiy liyiy mentioned this pull request Oct 5, 2023
Merged
@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

Size Change: +755 B (0%)

Total Size: 726 kB

Filename Size Change
dist/surveys.js 39.4 kB +755 B (+2%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 177 kB
dist/array.js 119 kB
dist/es.js 119 kB
dist/module.js 119 kB
dist/recorder-v2.js 95 kB
dist/recorder.js 58.3 kB

compressed-size-action

neilkakkar
neilkakkar reviewed Oct 6, 2023
View reviewed changes
src/extensions/surveys.ts Show resolved Hide resolved
src/extensions/surveys.ts Outdated Show resolved Hide resolved
src/extensions/surveys.ts Show resolved Hide resolved
src/extensions/surveys.ts Show resolved Hide resolved
@liyiy liyiy requested a review from neilkakkar October 6, 2023 16:07
@liyiy liyiy added bump patch Bump patch version when this PR gets merged bump minor Bump minor version when this PR gets merged and removed bump patch Bump patch version when this PR gets merged labels Oct 6, 2023
@liyiy
Copy link
Contributor Author

liyiy commented Oct 6, 2023

bump minor or patch? hmm... @neilkakkar

neilkakkar
neilkakkar approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every new feature is worth a minor release

@liyiy
Copy link
Contributor Author

liyiy commented Oct 6, 2023

I'll merge this Monday

@liyiy liyiy merged commit 09fa47f into master Oct 10, 2023
11 checks passed
@liyiy liyiy deleted the optional-survey-questions branch October 10, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilkakkar neilkakkar neilkakkar approved these changes

Assignees
No one assigned
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liyiy @neilkakkar