fix: Cross-subdomain tracking is not working for long TLDs

[MahdiGhiasi]

Changes

Fixes #786.

Changed DOMAIN_MATCH_REGEX variable from [a-z0-9][a-z0-9-]+\.[a-z.]{2,6}$ to [a-z0-9][a-z0-9-]+\.[a-z]{2,}$.

It accepts any domain with a TLD length of at least 2 characters, and extracts the domain name only.

(I'm not sure why there were a . in the final section of previous regex, as it also fails on cases such as me.you.co as well, where whole string matches with the previous pattern. The new pattern should work fine and extract the domain name.)

...

Checklist

• Tests for new code (see advice on the tests we use)
• Accounted for the impact of any changes across different browsers

[posthog-bot]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

[benjackwhite]

I think this looks good. Sorry for the delay on the review

[posthog-bot]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

[posthog-bot]

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

[MahdiGhiasi]

@benjackwhite @mariusandra When will this be merged? We're using PostHog and need this to track our users.

[jiito]

• 1 for this change. We have a .systems TLD and the multi-host tracking does not work because of this. Thanks for the fix @MahdiGhiasi