-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RemoteConfig loader #1577
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @benjackwhite! 👋 |
Size Change: +12.3 kB (+0.39%) Total Size: 3.19 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to work when hooked up with the parent PR though
so other than a though about error handling which might be fine 🚢
Co-authored-by: Paul D'Ambra <[email protected]>
Changes
Needs PostHog/posthog#26348
Work to implement the new RemoteConfig loader which will enable us to eventually replace
/decide
with/flags
This PR should not affect anything directly, but rather add a flagged
_preview_remote_config
option which will then load our new endpoint before calling decide (which we can then swap out for flags in the future).The big change for reviewers is moving away from
afterDecideResponse
toonRemoteConfig
which is almost the same as before. The things that require flags are changed to use theonFeatureFlags
callbacks instead.Checklist