Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify logic around top level opt in checks #1576

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benjackwhite
Copy link
Collaborator

Changes

See #1547 for more context

Need to discuss if this is valid and double check what the consequences are.

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 2, 2024 7:03pm

Copy link

github-actions bot commented Dec 2, 2024

Size Change: +90 B (0%)

Total Size: 3.18 MB

Filename Size Change
dist/array.full.es5.js 258 kB +9 B (0%)
dist/array.full.js 361 kB +9 B (0%)
dist/array.full.no-external.js 360 kB +9 B (0%)
dist/array.js 175 kB +9 B (+0.01%)
dist/array.no-external.js 174 kB +9 B (+0.01%)
dist/main.js 176 kB +9 B (+0.01%)
dist/module.full.js 361 kB +9 B (0%)
dist/module.full.no-external.js 360 kB +9 B (0%)
dist/module.js 175 kB +9 B (+0.01%)
dist/module.no-external.js 174 kB +9 B (+0.01%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.5 kB
dist/dead-clicks-autocapture.js 14.3 kB
dist/exception-autocapture.js 9.37 kB
dist/external-scripts-loader.js 2.29 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.2 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants