-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(flags): Add new debugging property $used_bootstrap_value
, $feature_flag_bootstrapped_response
and $feature_flag_bootstrapped_payload
to $feature_flag_called
event
#1567
Conversation
…response` and `$feature_flag_bootstrapped_payload` to `$feature_flag_called` event
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +5.21 kB (+0.16%) Total Size: 3.21 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamped with a comment about making sure this has parity for the other client-side SDKs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$feature_flag_bootstrapped_response
and $feature_flag_bootstrapped_payload
to $feature_flag_called
event$used_bootstrap_value
, $feature_flag_bootstrapped_response
and $feature_flag_bootstrapped_payload
to $feature_flag_called
event
@@ -32,6 +32,7 @@ describe('featureflags', () => { | |||
get_property: (key) => instance.persistence.props[key], | |||
capture: () => {}, | |||
decideEndpointWasHit: false, | |||
receivedFlagValues: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR we are essentially find+replacing the existing flag decideEndpointWasHit
for this new, more accurately named receivedFlagValues
flag. The prior will now mean that the endpoint truly was hit with no errors, and the latter will mean that there are flag values available for the SDK to return.
decideEndpointWasHit
is now really only used for passing back the $used_bootstrap_value
flag in $feature_flag_called events.
@dmarticus added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
third ship is the charm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
third ship is the charm
…tstrapped-flag-evt-property
…tstrapped-flag-evt-property
…tstrapped-flag-evt-property
…tstrapped-flag-evt-property
testcafe/check-testcafe-results.js
Outdated
@@ -47,7 +47,7 @@ If they seem to be failing unexpectedly, check grafana for ingestion lag at http | |||
log(JSON.stringify(files, null, 2)) | |||
|
|||
// the deadline is the same for each assert, as the ingestion lag will be happening in parallel | |||
const deadline = Date.now() + 1000 * 60 * 30 // 30 minutes | |||
const deadline = Date.now() + 1000 * 60 * 120 // 30 minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pedantic, but you should change the comment to match the time (it's 120 minutes now).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping to not leave this around, but may do so depending on what others think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah fair 'nuff
…tstrapped-flag-evt-property
…tstrapped-flag-evt-property
Changes
Same change for bootstrapping as PostHog/posthog-js-lite#320
Checklist