fix: patch angular wrap detection in rrweb #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pauldambra
commented
Nov 19, 2024
patches/@[email protected]
Outdated
Comment on lines
9
to
16
| +const isFunction = (x) => typeof x === 'function'; | ||
| +const isNativeFunction = () => isFunction(x) && x.toString().includes("[native code]"); | ||
| +const isAngularZonePatchedFunction = (x) => { | ||
| + if (!isFunction(x)) { | ||
| + return false; | ||
| + } | ||
| + const prototypeKeys = Object.getOwnPropertyNames(x.prototype || {}); | ||
| + return prototypeKeys.some((key) => key.indexOf('__zone')); | ||
| +} |
There was a problem hiding this comment.
copies these three functions from posthog-js that are already being used in #1531
pauldambra
commented
Nov 19, 2024
patches/@[email protected]
Outdated
Comment on lines
35
to
40
| + let isUntainted = isNativeFunction(candidate); | ||
| + if (key === 'MutationObserver') { | ||
| + isUntainted = isUntainted && !isAngularZonePatchedFunction(candidate); | ||
| + } | ||
| + return isUntainted; | ||
| + }), |
There was a problem hiding this comment.
when testing mutation observer it has to be native code and not have angular zone prototypes
|
Size Change: +1.04 kB (+0.03%) Total Size: 3.12 MB
ℹ️ View Unchanged
|
marandaneto
approved these changes
Nov 19, 2024
|
|
pauldambra
force-pushed
the
fix/patch-angular-wrap-detection-in-rrweb
branch
from
113a71e to
702929a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #1531 which fixed this for dead clicks
patch rrweb to correctly detect angular's change detection
🎉 tested locally by installing patched version in an angular application and seeing it no longer freezes 🎉
also opened upstream PR here rrweb-io/rrweb#1597