-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve ES6 bundling #1542
Merged
pauldambra
merged 9 commits into
main
from
fix/remove-ie11-from-main-supported-browsers
Nov 20, 2024
Merged
fix: improve ES6 bundling #1542
pauldambra
merged 9 commits into
main
from
fix/remove-ie11-from-main-supported-browsers
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +16.6 kB (+0.53%) Total Size: 3.14 MB
ℹ️ View Unchanged
|
pauldambra
changed the title
fix: remove ie11 from main supported browsers
fix: improve ES6 bundling
Nov 20, 2024
marandaneto
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
low context n. N :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1525 - IE 11 tests are freezing in that PR and it's really hard to figure out why
have pulled many small changes out of that PR but the IE 11 tests still freeze
Does not update the browserslist value in package.json, since that is the change that appears to make CI freeze
I'd rather get the benefit of the ES6 compliant bundle in prod before fixing that