Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return this if already loaded #1092

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix: Return this if already loaded #1092

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1930b87
Return this if already loaded
benjackwhite Mar 20, 2024
d613136
Fix to always return
benjackwhite Mar 20, 2024
f6f133e
Added tests
benjackwhite Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/posthog-core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,17 +299,17 @@ export class PostHog {
// IE11 compatible. We could use polyfills, which would make the
// code a bit cleaner, but will add some overhead.
//
_init(token: string, config: Partial<PostHogConfig> = {}, name?: string): PostHog | void {
_init(token: string, config: Partial<PostHogConfig> = {}, name?: string): PostHog {
if (_isUndefined(token) || _isEmptyString(token)) {
logger.critical(
'PostHog was initialized without a token. This likely indicates a misconfiguration. Please check the first argument passed to posthog.init()'
)
return
return this
}

if (this.__loaded) {
logger.warn('You have already initialized PostHog! Re-initialising is a no-op')
return
return this
}

this.__loaded = true
Expand Down
Loading