Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return this if already loaded #1092

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix: Return this if already loaded #1092

merged 3 commits into from
Mar 20, 2024

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Mar 20, 2024

Changes

Related to #1090

We don't return posthog if the SDK is already initialised or if the token is missing. This appears to be a regression

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Mar 20, 2024
@benjackwhite benjackwhite requested a review from neilkakkar March 20, 2024 13:12
Copy link

github-actions bot commented Mar 20, 2024

Size Change: +64 B (0%)

Total Size: 941 kB

Filename Size Change
dist/array.full.js 224 kB +16 B (0%)
dist/array.js 124 kB +16 B (0%)
dist/es.js 124 kB +16 B (0%)
dist/module.js 124 kB +16 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.1 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 106 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@neilkakkar neilkakkar changed the title Return this if already loaded fix: Return this if already loaded Mar 20, 2024
@benjackwhite benjackwhite merged commit 6fd350d into main Mar 20, 2024
15 checks passed
@benjackwhite benjackwhite deleted the fix/loaded-init branch March 20, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants