From 5548ae4fe832f0122b4dc96cbab3b173935076e9 Mon Sep 17 00:00:00 2001 From: Ben White Date: Wed, 4 Dec 2024 13:27:45 +0100 Subject: [PATCH] Fix comments --- src/decide.ts | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/decide.ts b/src/decide.ts index 029434ed8..e91c04e79 100644 --- a/src/decide.ts +++ b/src/decide.ts @@ -5,16 +5,6 @@ import { STORED_GROUP_PROPERTIES_KEY, STORED_PERSON_PROPERTIES_KEY } from './con import { logger } from './utils/logger' import { assignableWindow, document } from './utils/globals' -// TODO: Add check for global config existing. -// Modify the whole "afterDecideResponse" function to be a method of the PostHog class - -// 1. Option is to load the config endpoint (if __preview is enabled) and then if flags are needed call decide, and then call "afterDecideResponse" with the combined response :thinking: -// 2. Other option is to separate out the values so that we have a "config response" and a "flags response" separately... - -// TODO: Fix WebExperiments to wait for flags instead of only decide -// TODO: Fix Surveys to do the same -// TODO: Background refresh of the config - every 5 minutes to match CDN cache - at least when active - export class Decide { constructor(private readonly instance: PostHog) { // don't need to wait for `decide` to return if flags were provided on initialisation